BB 43322: Customize the font visibility lists.

Merge Info

Issues

Resolves

• tor-browser#xxxxx
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Related

• #43322
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Merging

Target Branches

• tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

• Alpha: esr128-14.5
• Stable: esr128-14.0
• Legacy: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

/cc @thorin

Change Description

In this commit, we introduce custom fontvis lists. However, they won't be active, yet, as we still define font.system.whitelist for now.

The idea is to enable testing with this functionality, but we're not sure enough to disable it.

We might want to contact upstream to discuss this change.

How Tested

1. Check that everything is fine in TZP
2. Manually change font.system.whitelist to be empty
3. Check that TZP doesn't report any change

assigned to @pierov

mentioned in issue #43322

added 2 commits

• 91211b88 - fixup! Bug 43140: Tighten up fonts on Linux.
• f0e18e41 - Bug 43322: Customize the font visibility lists.

Compare with previous version

Testbuilds:

• https://tb-build-03.torproject.org/~pierov/testbuild/tor-browser-linux-x86_64-testbuild-1316.tar.xz
• https://tb-build-03.torproject.org/~pierov/testbuild/tor-browser-windows-x86_64-portable-testbuild-1316.exe

marked this merge request as ready

added 6 commits

• f0e18e41...7dc11c34 - 4 commits from branch tpo/applications:tor-browser-128.5.0esr-14.5-1
• e42598dc - fixup! Bug 43140: Tighten up fonts on Linux.
• 145b17ea - Bug 43322: Customize the font visibility lists.

Compare with previous version

marked this merge request as draft from pierov/tor-browser@e42598dc

marked this merge request as ready

requested review from @morgan

added 1 commit

• 32022ebd - Temporary commit: add bundled fonts to the vislist.

Compare with previous version

added 1 commit

• 9513fce6 - Temporary commit: add bundled fonts to the vislist.

Compare with previous version

lgtm so far, marking as DRAFT: feel free to merge when you two are happy.

marked this merge request as draft

Including the bundled fonts in the list doesn't improve performance, so I'll merge without that commit.

We can fix it for #43369.

added 4 commits

• 9513fce6...7f8c1d43 - 2 commits from branch tpo/applications:tor-browser-128.5.0esr-14.5-1
• aaf57ee1 - fixup! Bug 43140: Tighten up fonts on Linux.
• 5333f638 - Bug 43322: Customize the font visibility lists.

Compare with previous version

marked this merge request as ready

resolved all threads

enabled an automatic merge when all merge checks for 5333f638 pass

merged

Cherry-picked as 107f6329+491be80b, mullvad-browser@334a5ddd+mullvad-browser@3b5a4ebe.