Skip to content

No bug: Merger request pipelines are failing due to incorrect branch name

brizental requested to merge brizental/tor-browser:no-bug-fix-pipelines into tor-browser-128.6.0esr-14.5-1

Merge Info

Merging

Target Branches

  • tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Backporting

Timeline

  • No Backport (preferred): patchset for the next major stable
  • Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport

Review

Change Description

Something seems to have changes in the way Gitlab runs pipelines and it seems fork pipelines are now run in the context of the parent project. That was breaking MR pipelines due to incorrect branch name. Just to be sure I kept the previous approach and set the new one as a fallback in case that fails. The failing doesn't add almost any overhead in terms of time, so we are good.

How Tested

If pipelines in this MR pass, we are good.

Merge request reports