Convert "quickstart" checkbox into a "connect automatically" toggle

Merge Info

Issues

Resolves

• #43469 (closed)

Related

Merging

Target Branches

• tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

• Alpha: esr128-14.5
• Stable: esr128-14.0
• Legacy: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Uplifting

• Patchset is a candidate for uplift to Firefox

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

Change Description

We convert the xul:checkbox into moz-toggle, and we change the heading and description text.

How Tested

Made sure the initial value was correctly loaded, when enabled or not. Made sure it stayed in sync with about:torconnect.

requested review from @morgan

assigned to @henry

@donuts and @felicia please review the wording and use of the toggle instead of checkbox.

marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

approved this merge request

added 20m of time spent

Thanks @henry, agree it's looking great!

Connect to the Tor network automatically when launched, using your current connection settings.

Do you think it would be better to say "...when Tor Browser is launched", to be more specific?

requested changes

added 8 commits

• a189e899...1f7e489c - 6 commits from branch tpo/applications:tor-browser-128.7.0esr-14.5-1
• b47d7100 - fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in...
• a6071589 - fixup! Tor Browser strings

Compare with previous version

marked this merge request as draft from henry/tor-browser@b47d7100

added 1 commit

• 65368a6e - fixup! Tor Browser strings

Compare with previous version

marked this merge request as ready

Just a matter of information, I believe the "Quickstart" section in the Glossary should be updated, right?

resolved all threads

mentioned in issue #43527 (closed)

mentioned in issue tpo/web/manual#184 (closed)

resolved all threads

added 13 commits

• 65368a6e...85e00bd3 - 11 commits from branch tpo/applications:tor-browser-128.7.0esr-14.5-1
• e21ae62e - fixup! TB 31286: Implementation of bridge, proxy, and firewall settings in...
• 10c9315c - fixup! Tor Browser strings

Compare with previous version

marked this merge request as draft from henry/tor-browser@e21ae62e

marked this merge request as ready