Skip straight to "FinalError" if we do not get an expected TorConnectError

Merge Info

Issues

Resolves

• #43488 (closed)

Related

Merging

Target Branches

• tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

• Alpha: esr128-14.5
• Stable: esr128-14.0
• Legacy: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Upstream

• Patchset is a candidate for uplift to Firefox
• Patchset is a backport from Firefox
  • Bugzilla link:
  • Upstream commit:

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since Gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

Change Description

We only progress through the connect assist stages if we get an expected error type. If we get anything else, including a Moat connection error, we skip straight to FinalError.

For android, this means that if Moat is broken for that user then we would skip to FinalError why they try and auto bootstrap.

How Tested

The torbrowser.debug.censorship_level levels work as expected.

If we simulate an empty response from Moat with

TorConnect.simulateBootstrapOptions.simulateMoatResponse = { bridgesList: [] };

or

TorConnect.simulateBootstrapOptions.simulateMoatResponse = { country: "fi", bridgesList: [] };

we move from ChooseRegion to RegionNotFound and ConfirmRegion, respectively.

If we force Moat to fail, we move to FinalError instead.

If we force the BootstrapAttempt to throw, it will proceed directly from Start to FinalError.

requested review from @pierov

assigned to @henry

approved this merge request

added 5 commits

• d9dd83c8...f37f63bc - 4 commits from branch tpo/applications:tor-browser-128.8.0esr-14.5-1
• 4aeac6bb - fixup! TB 40597: Implement TorSettings module

Compare with previous version

marked this merge request as draft from henry/tor-browser@4aeac6bb

marked this merge request as ready

merged

marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed