Modify the urlbar for Base Browser

Merge Info

Issues

Resolves

Related

• #43864 (closed). Need mullvad-browser merge request to close.

Merging

Target Branches

• tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • "fixup! BB 42583: Modify moz-support-link for Base Browser."
  • "BB 43864: Modify the urlbar for Base Browser."
  • NOTE: mullvad-browser's should be done in a new merge request.

Target Channels

• Alpha: esr140-15.0
• Stable: esr128-14.5
• Legacy: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Upstream

• Patchset is a candidate for uplift to Firefox
• Patchset is a backport from Firefox
  • Bugzilla link:
  • Upstream commit:

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /request_review all the relevant reviewers
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • ci/cd: brizental, henry
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : brizental, clairehurst, dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

Change Description

We:

1. Hide the "History" item from the urlbar drop down search menu when using permanent private browsing.
2. Hide the actions for extensions. The action for themes remains.
3. Hide the actions for clearing history for permanent private browsing.
4. Hide the action for firefoxview.
5. Point the "Tor Browser help" action to the url https://support.torproject.org/tbb/.
6. Replace the support link with a base-browser preference value. <moz-support-link> is modified to use this preference value.

How Tested

In permanent private browsing:

1. History item is hidden from the urlbar drop down menu (next to "Bookmarks" and "Tabs").
2. Click the "Actions" item. Extension items, firefoxview, and "Clearing history" are hidden.
3. Typing in "clear" or "history" or "extensions" in the urlbar will not suggest an action.
4. Clicking "Tor Browser help" will take you to https://support.torproject.org/tbb/.
5. The "Tor Browser Nightly Support" link in about:preferences takes you to https://support.torproject.org/tbb/.

With history on:

1. History item is visible.
2. "Clear recent history" appears in the actions list.