Skip to content

Bug 41197 - [android] Disable autofill

brizentalrequested to merge
brizental/tor-browser:41197-no-autofill into tor-browser-140.2.0esr-15.0-1

Merge Info

Issues

Resolves

Merging

Target Branches

  • tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

  • Alpha: esr140-15.0
  • Stable: esr128-14.5
  • Legacy: esr115-13.5

Backporting

Timeline

  • No Backport (preferred): patchset for the next major stable
  • Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport

Review

Change Description

Firefox is an Autofill service. From the Android docs:

An autofill service is an app that makes it easier for users to fil out forms by injecting data into the views of other apps. Autofill services can also retrieve user data from the views in an app and store it for use at a later time. Autofill services are usually provided by apps that manage user data, such as password managers.

Tor Browser is not an autofill service. All of the autofill backend is disabled at build time, since it lives in application-services.

This commit disabled the client side of autofill.

See also: #41197 (comment 3238075)

How Tested

Build and ran some basic tests manually.

Also checked that the autofill service is gone, by using

adb shell dumpsys package org.torproject.torbrowser | grep AUTOFILL

Closes to #41197 (closed)

Merge request reports