Bug_44081: Swiping away the "private tabs" notification requires rebootstrapping

Merge Info

Issues

Resolves

• #44081 (closed)

Merging

Target Branches

• tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• base-browser and mullvad-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • ⚠️ IMPORTANT: Please list the base-browser-specific commits which need to be cherry-picked to the base-browser and mullvad-browser branches here

Target Channels

• Alpha: esr140-15.0
• Stable: esr128-14.5
• Legacy: esr115-13.5

Backporting

Timeline

• No Backport (preferred): patchset for the next major stable
• Immediate: patchset needed as soon as possible (fixes CVEs, 0-days, etc)
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport

(Optional) Justification

• Security update: patchset contains a security fix (be sure to select the correct item in Timeline)
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Upstream

• Patchset is a candidate for uplift to Firefox
• Patchset is a backport from Firefox
  • Bugzilla link:
  • Upstream commit:

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /request_review all the relevant reviewers
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • ci/cd: brizental, henry
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : jwilde, ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, morgan
  • localization : henry, pierov
  • macOS : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : brizental, clairehurst, dan, ma1, pierov, morgan
  • security : jwilde, ma1
  • signing : boklm, morgan
  • updater : pierov
  • windows : jwilde, morgan
  • misc/other : pierov, morgan

Change Description

Made swiping the notification away not destroy the app by setting the boolean shouldShutDownWithOnDestroyWhenIsFinishing in the NotificationsDelegate to false after the notification is swiped or tapped. This boolean is checked inside HomeActivity's onDestroy to see if everything (including the tor daemon) should be destroyed.

How Tested

Check that #44081 (closed) is fixed.

Bootstrap and open a tab (any tab). Make sure swiping the notification away or tapping it does not restart the app and does not require re-bootstrapping. Check when the app is backgrounded as well, as there is a slightly different flow for when the app is backgrounded.

Also check that #43645 (closed) did not regress since this modifies and moves the fix for that code. Make sure closing the app does require re-bootstrapping. Check by bootstrapping and swiping the app away, hitting the "exit button" from the drop down settings (from both on the landing page/no tab page and also when a tab is open), or any other way to close the app.