Skip to content
Snippets Groups Projects

Bug 41304: Add Android-specific targets to makefiles

2 unresolved threads

Add Android-specific targets to makefiles (only fat-aar for the moment).

Also, added a mozconfig file to use for this.

We might think to a better way to handle this, because we might need to customize the mozconfig we use like we do on desktop.

For example, in my mozconfig I have:

ac_add_options --with-java-bin-path=/usr/lib/jvm/java-11-openjdk-amd64/bin
ac_add_options --with-android-sdk=/home/piero/Tor/android-toolchain/android-sdk-linux

I think we could add a non-versioned shell file that is sourced by the various script and adds some local config variables.

Another idea is not versioning the -dev android file, but creating it only locally (and remember to add the default channel setting).

Fixes #41304 (closed).

Edited by Pier Angelo Vendrame

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    • 7e665664 - fixup! fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser

    Compare with previous version

  • Pier Angelo Vendrame marked this merge request as draft from pierov/tor-browser@7e665664

    marked this merge request as draft from pierov/tor-browser@7e665664

  • Pier Angelo Vendrame marked this merge request as ready

    marked this merge request as ready

    • for

      ac_add_options --with-java-bin-path=/usr/lib/jvm/java-11-openjdk-amd64/bin
      ac_add_options --with-android-sdk=/home/piero/Tor/android-toolchain/android-sdk-linux

      you could add them either commented out, or not which would force fixing if wrong

      ac_add_options --with-java-bin-path=/usr/lib/jvm/java-11-openjdk-amd64/bin
      ac_add_options --with-android-sdk=$HOME/Android/Sdk

      (I beleive $HOME/Android/Sdk is defaultish)

    • you could add them either commented out, or not which would force fixing if wrong

      Very good idea!

      (I beleive $HOME/Android/Sdk is defaultish)

      Yes, I have SDKs also there, but not sure about their version.

    • Please register or sign in to reply
  • added 1 commit

    • f856dbaa - fixup! fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser

    Compare with previous version

  • Pier Angelo Vendrame marked this merge request as draft from pierov/tor-browser@f856dbaa

    marked this merge request as draft from pierov/tor-browser@f856dbaa

  • Pier Angelo Vendrame marked this merge request as ready

    marked this merge request as ready

  • added 1 commit

    • 4b20df67 - fixup! fixup! TB3: Tor Browser's official .mozconfigs.

    Compare with previous version

  • Pier Angelo Vendrame marked this merge request as draft from pierov/tor-browser@4b20df67

    marked this merge request as draft from pierov/tor-browser@4b20df67

  • Pier Angelo Vendrame marked this merge request as ready

    marked this merge request as ready

  • ok, the others seem happy with this now. Just need to squash the commits before merging

  • henry approved this merge request

    approved this merge request

  • added 2 commits

    • 641bbefd - fixup! Bug 41089: Add tor-browser build scripts + Makefile to tor-browser
    • e7e60d23 - fixup! TB3: Tor Browser's official .mozconfigs.

    Compare with previous version

  • Pier Angelo Vendrame marked this merge request as draft from pierov/tor-browser@641bbefd

    marked this merge request as draft from pierov/tor-browser@641bbefd

  • Pier Angelo Vendrame marked this merge request as ready

    marked this merge request as ready

  • Please register or sign in to reply
    Loading