Bug 40491: Don't auto-pick a v2 address when it's in Onion-Location header

We could do a more strict validation on the v3 host, if needed.

Also linted/formatted Document.cpp before applying the new patch.

Closes #40491 (closed).

assigned to @pierov

added 2 commits

• 8ee2a04b - fixup! Bug 27476: Implement about:torconnect captive portal within Tor Browser
• 400275a5 - fixup! Bug 21952: Implement Onion-Location

Compare with previous version

marked this merge request as draft from pierov/tor-browser@8ee2a04b

marked this merge request as ready

requested review from @henry

added 1 commit

• d1c50a4f - fixup! Bug 21952: Implement Onion-Location

Compare with previous version

marked this merge request as draft from pierov/tor-browser@d1c50a4f

marked this merge request as ready

Uhm. I don't like it that much, with all these macros. But I guess that's what Firefox C++ looks like.

@richard do you have additional thoughts?

resolved all threads

added 1 commit

• 87d02085 - fixup! Bug 21952: Implement Onion-Location

Compare with previous version

marked this merge request as draft from pierov/tor-browser@87d02085

Looks good to me. Much clearer than the old code now as well :)

approved this merge request

added 2 commits

• 2c885618 - fixup! Bug 21952: Implement Onion-Location
• bc515cc7 - fixup! Bug 40458: Implement .tor.onion aliases

Compare with previous version

added 1 commit

• dae0e8fa - fixup! Bug 40458: Implement .tor.onion aliases

Compare with previous version

marked this merge request as ready

This was my test for v2 (but you need to temporarily disable the HTTPS test):

from http.server import HTTPServer, SimpleHTTPRequestHandler


class OnionLocationHandler(SimpleHTTPRequestHandler):
    def end_headers(self):
        self.send_header(
            "Onion-Location", "http://www.aa234567aaa23456.onion/a"
        )
        SimpleHTTPRequestHandler.end_headers(self)


httpd = HTTPServer(("0.0.0.0", 3000), OnionLocationHandler)
httpd.serve_forever()

lgtm assumin gyou've also validated the existing popular onion-location pages still work (nytimes, facebook, reddit, twitter, etc).

approved this merge request

merged

resolved all threads