Skip to content

Bug 41603: Customize the creation of MOZ_SOURCE_URL

Merge Info

Related Issues

  • #41603 (closed)

  • tor-browser-build#40764 (closed)

  • Backport Timeline

    • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
    • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
    • Eventually - patchset that needs to be verified in alpha before backport
    • No Backport - patchset for the next major stable
  • Upstream Merging

    • Merge to base-browser - typically for !fixups to patches in the base-browser branch, though sometimes new patches as well
      • NOTE: if your changeset includes patches to both base-browser and tor-browser please please make separate merge requests for each part
    • Merge to Privacy Browser
  • Issue Tracking

Change Description

MOZ_SOURCE_URL is created from MOZ_SOURCE_REPO and MOZ_SOURCE_CHANGESET, combined as $MOZ_SOURCE_REPO/rev/$MOZ_SOURCE_CHANGESET.

This works for Mercurial, but not for GitLab.

So, this commit changes the creation of MOZ_SOURCE_URL to match what GitLab does.

At the moment, I've glued the variables with /-/commit/, since it's the closest equivalent to /rev/, but it works only for Git hashes.

We could change it with /-/tree/ if we wanted to support also tags (or even branches, but I think that branches defeat the idea of having a precise source point).

Edited by Pier Angelo Vendrame

Merge request reports