Skip to content

Bug 41678: Correct the typedef for pid_t in WebRTC for Windows

morgan requested to merge morgan/tor-browser:bug_41678 into base-browser-102.9.0esr-12.5-1

Merge Info

  • Related Issues

  • Backport Timeline

    • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
    • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
    • Eventually - patchset that needs to be verified in alpha before backport
    • No Backport - patchset for the next major stable

  • Upstream Merging

    • Merge to base-browser - typically for !fixups to patches in the base-browser branch, though sometimes new patches as well
      • NOTE: if your changeset includes patches to both base-browser and tor-browser please please make separate merge requests for each part

  • Issue Tracking

Change Description

So pid_t is defined for Windows as an int/int32_t in MingW (which you can verify in mingw's sys/types.h header), so we follow that same convention for MSVC. This is a bit weird because a process ID on windows is a DWORD which is an uint32_t for all architectures. But, we never do math with a PID so the signed/unsigned difference is probably fine. Verified base-browser still builds for windows for both i686 and x86_64 architectures.

Merge request reports