Skip to content

Bug 41698: Reword the recommendation badges in about:addons

Pier Angelo Vendrame requested to merge pierov/tor-browser:bug_41698 into tor-browser-102.9.0esr-12.5-1

Merge Info

Related Issues

Backport Timeline

  • Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
  • Next Minor Stable Release - patchset that needs to be verified in nightly before backport
  • Eventually - patchset that needs to be verified in alpha before backport
  • No Backport - patchset for the next major stable

Upstream Merging

  • Merge to base-browser - typically for !fixups to patches in the base-browser branch, though sometimes new patches as well
    • NOTE: if your changeset includes patches to both base-browser and tor-browser please please make separate merge requests for each part

Issue Tracking

Change Description

We want to change the strings Firefox uses for addon badges because we want them to explicitly mention Mozilla, instead of showing "Tor Browser recommends ...".

Weblate doesn't support Fluent attributes, so I had to inject strings in JS once again.

I've talked to emmapeel, and we decided to keep using the same file as the language notification for now, to keep stuff simpler, and avoiding losing any "reviewed" status on the already translated strings.

However, I decided to create a new commit for the strings, like the TorStrings one.

Finally, we have an upstream bug, so I'm keeping this one isolated, instead of creating a fixup, to make revert it easier, in case they decide to change strings upstream.

Merge request reports