Bug 41709: Reimplement the failure logic for TorProtocolService.sendCommand

Merge Info

Related Issues

• #41709 (closed)
• tor-browser-build#xxxxx
• etc

Backport Timeline

• Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
• Next Minor Stable Release - patchset that needs to be verified in nightly before backport
• Eventually - patchset that needs to be verified in alpha before backport
• No Backport - patchset for the next major stable

Upstream Merging

• Merge to base-browser - typically for !fixups to patches in the base-browser branch, though sometimes new patches as well
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please please make separate merge requests for each part

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Change Description

The previous logic for sendCommand was to try to call itself after a while... This means it continued doing so forever, which isn't good.

Therefore, I've added a maximum number of attempts, after which it gives up and throws (or it makes someone else throw).