Bug 41816: Workaround to fix the top navigation

Merge Info

Related Issues

• #41816 (closed)

Backport Timeline

• Immediate - patchsets for critical bug fixes or other major blocker (e.g. fixes for a 0-day exploit) OR patchsets with trivial changes which do not need testing (e.g. fixes for typos or fixes easily verified in a local developer build)
• Next Minor Stable Release - patchset that needs to be verified in nightly before backport
• Eventually - patchset that needs to be verified in alpha before backport
• No Backport - patchset for the next major stable

Upstream Merging

• Merge to base-browser - typically for !fixups to patches in the base-browser branch, though sometimes new patches as well
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please please make separate merge requests for each part
• Not for merge

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Change Description

The about:torconnect page is quite messy, because we have two different state variables (UI states don't overlap with connection states - maybe I should have fixed that, instead).

For some reason (I don't remember it), we always pass the connection state as a function argument.
I don't think it makes a lot of sense, now, but I don't want to refactor everything. We already have #41710 for that.

However, we have a small problem: when we use the top/breadcrumb navigation, we don't pass the connection state, and as a result, we have only a partial update (and an error in the console). As a quick workaround, I thought of getting the connection state directly from the parent, as it seems the less risky change (change localized only to the failing part of the code), at this moment (12.5 RC scheduled for this afternoon).

The diff seems bigger than it actual is because of linting.

/cc @henry @richard