Critical bug-fix: patchset fixes a bug in core-functionality
Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
Sponsor required: patchset required for sponsor
Other: please explain
Merging
Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging
Issue Tracking
Link resolved issues with appropriate Release Prep issue for changelog generation
Review
Request Reviewer
Request review from an applications developer depending on modified system:
NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
accessibility : henry
android : clairehurst, dan
build system : boklm
extensions : ma1
firefox internals (XUL/JS/XPCOM) : ma1
fonts : pierov
frontend (implementation) : henry
frontend (review) : donuts, richard
localization : henry, pierov
macos : clairehurst, dan
nightly builds : boklm
rebases/release-prep : dan, ma1, pierov, richard
security : ma1
signing : boklm, richard
updater : pierov
misc/other : pierov, richard
Change Description
Center the select in about:torconnect.
I think only line-height works reliably for selects. The padding-top would also work, but it's probably a worse solution.
Sadly, min-height is set instead of height, but I don't know of cases for which that min-height would be not enough.
Screenshot
How Tested
Triggered the connection assist with torbrowser.debug.censorship_level set to 3 to make the select visible.
Pier Angelo Vendrame authored