Bug 42182: avoid reloading any search engine extension.

Merge Info

Related Issues

• #42182 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

Rather than just looking at the extension's ID to guess whether it's a search engine or not, like the original patch naively did, here we parse and examine its manifest so we catch also spurious search engine which do not identify as *@search.mozilla.org.

How Tested

Followed he steps to reproduce in #42182 (closed)'s description. Checked that temporary permissions given to a website from NoScript's UI are forgot on new identity (i.e. we're not regressing #41833 (closed)).

requested review from @richard

assigned to @ma1

added 4 commits

• 83dc5117...18023383 - 3 commits from branch tpo/applications:tor-browser-115.4.0esr-13.5-1
• 14f080cd - fixup! Bug 40926: Implemented the New Identity feature

Compare with previous version

marked this merge request as draft from ma1/tor-browser@14f080cd

marked this merge request as ready

approved this merge request

marked the checklist item Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports as completed

marked the checklist item Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports as completed

merged

cherry-picked to base-browser as 322d308f and mullvad-browser as mullvad-browser@77c1e6b0

marked the checklist item Eventually: patchset that needs to be verified in alpha before backport as completed

marked the checklist item Next Minor Stable Release: patchset that needs to be verified in nightly before backport as incomplete

marked the checklist item Next Minor Stable Release: patchset that needs to be verified in nightly before backport as completed

marked the checklist item Eventually: patchset that needs to be verified in alpha before backport as incomplete