Make torconnect redirect compatible with blank home page.

Merge Info

Related Issues

• #42184 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

We drop the restriction that the redirect URI scheme must be "http" "https" or "about". This allows us to redirect to the blank page at "chrome://browser/content/blanktab.html".

This logic is moved to the window actor, where we have the privilege to redirect to "chrome" URIs.

How Tested

1. Change home page settings to "Tor Browser Home", "Blank" or a custom value (like "example.org", or "example.net|example.org"). The initial "about:torconnect" page(s) should redirect to the setting.
2. Pass in some urls as extra arguments to start-tor-browser. The urls should be reached from the initial page(s).
3. After launching, close the initial "about:torconnect" page. Go to blank page and press the "Connect" button in the url. New page should redirect to the (first) home page.
4. Open "about:torconnect" after bootstrapping. Should redirect to the (first) home page.
5. Open "about:torconnect" with TOR_SKIP_LAUNCH=1. Should redirect to the (first) home page.