Bug 42306: Prevent crashes and actually clear the clipboard on Wayland

Merge Info

Related Issues

• #42306 (closed)
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

How Tested

Checked that:

1. The old behavior is kept identical on X11 (content copied from private windows is removed from the clipboard on shutdown)
2. The crash on extension popup with MOZ_WAYLAND_ENABLED=1 doesn't happen anymore
3. Content copied from private windows is removed from the clipboard on shutdown with MOZ_WAYLAND_ENABLED=1 as well

requested review from @richard

assigned to @ma1

mentioned in issue #42306 (closed)

marked the checklist item Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports as completed

As I wrote on IRC, I still have a few doubts about this protection, I'm wondering if we should revert it instead (or maybe revert it from stable, let the new version bake a little bit in alpha before backporting it and re-enable it).

Maybe I'm missing something, but I think this gives us the possibility to re-evaluate the initial decision we took for 13.0.

The original issues (#42019 (closed) and #42013 (closed)) are tagged Linkability, but I'd say clipboard isn't a linkability threat on content. Firefox still doesn't support clipboard reading, except for extensions and with a dedicated pref set to true (default is false).

For all the other threats, we don't do anything while the browser is running (which makes sense, doing anything more than this about the clipboard would be a great usability issue).

But again, maybe I'm not considering something.

Maybe could we talk about this in this afternoon's meeting?

added 1 commit

• 80d7e717 - fixup! Bug 42019: Empty browser's clipboard on browser shutdown

Compare with previous version

marked this merge request as draft from ma1/tor-browser@80d7e717

Lint please .

lint.diff

added 1 commit

• 410b9a4c - fixup! Bug 42019: Empty browser's clipboard on browser shutdown

Compare with previous version

resolved all threads

approved this merge request

marked this merge request as ready

approved this merge request

resolved all threads

merged

• Cherry-picked as base-browser@2a4e21db
• Backported on stable 13.0 as tor-browser@1a9bf95b and base-browser@d101548d

marked the checklist item Immediate: patchset needed as soon as possible as completed