Bug 42376: Pass the locale list when constructing l10n in datetimebox

Merge Info

Related Issues

• #42376 (closed)
• mullvad-browser#xxxxx
• tor-browser-build#xxxxx

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

No 13.0.9, but maybe 13.5a4 and 13.0.10.

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging
• Uplift to upstream

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

If you go to https://arkenfox.github.io/TZP/tests/applang.html, you can notice that when you use spoof English, all the widgets but the datetime have English text. It's especially visible with non-Latin languages, such as ar.

This is bad for reasons explained in #42376 (closed).

So, we could honor the request to spoof English and display the English placeholders. Please notice that the formatting will already happen in en-US, only the strings are wrong.

So, we fix a bad thing, and eventually gain in consistency 🏆.

How Tested

Checked https://arkenfox.github.io/TZP/tests/applang.html before and after the change with ar, and checked that after the change, when you don't have spoof English, you have the correct placeholders.

Screenshots

Current state:

Desired state/state after the patch (not distinguishable from en-US, from what I can tell):

State without spoof English: