Bug 42236: Let users decide whether to load their home page on new identity.

Merge Info

Related Issues

• #42236 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

How Tested

1. Set a custom URL as the home page in about:preferences#home
2. Request a new identity
3. Verify that a notification bar is shown and you can choose to ignore it (by navigating away or closing it with the [x] button)
4. Verify that if you ignore it and you repeat step #2, the same notification is shown again
5. Verify that if you dismiss the notification using the [Load it anyway] button, the custom home page is loaded and the notification is not shown anymore on new identity requests
6. Change the custom URL to a different one
7. Repeat steps 2-3

requested review from @richard

assigned to @ma1

marked the checklist item Eventually: patchset that needs to be verified in alpha before backport as completed

marked the checklist item Link resolved issues with appropriate Release Prep issue for changelog generation as completed

added 1 commit

• 9889fff1 - fixup! Bug 40926: Implemented the New Identity feature

Compare with previous version

marked this merge request as draft from ma1/tor-browser@9889fff1

marked this merge request as ready

added 1 commit

• 2a3aa856 - fixup! Bug 40926: Implemented the New Identity feature

Compare with previous version

marked this merge request as draft from ma1/tor-browser@2a3aa856

added 1 commit

• 914200fb - fixup! Bug 40926: Implemented the New Identity feature

Compare with previous version

marked this merge request as ready

requested review from @pierov and removed review request for @richard

changed the description

Please lint

Running new identity before bootstrapping will show the bar also in about:torconnect. Clicking on load anyway will redirect me to about:blank (I have about:blank because debug builds usually crash in about:tor).

I think we should detect it's about:torconnect and not show the notification in case (I don't know if we want to do it in the commit that goes to Base Browser, or if we should do it in a commit on the Tor Browser part).

For about:blank it says browser, because it saves it as chrome://browser/content/blanktab.html.

Maybe could we add an if and call it about:blank, or give it the same name used in about:preferences (so we don't have to add strings) (Blank Page in en-US)?

I haven't tried file:// yet, but it might have similar surprises.