Bug 41918: Option to reuse last window size when letterboxing is enabled.

Merge Info

Related Issues

• #41918 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

How Tested

1. Run the Tor Browser and verify that first window is of the expected rounded size (1400x900), but new ones reuse possibly resized dimension as long as letterboxing is enabled
2. Turn the privacy.resistFingerprinting.letterboxing pref to false and verify that new windows get properly force-rounded
3. Turn the new privacy.resistFingerprinting.letterboxing.rememberSize pref to false and revert privacyprivacy.resistFingerprinting.letterboxing to its default (true), and verify that new windows get properly force-rounded
4. Revert privacy.resistFingerprinting.letterboxing.rememberSize pref to its default (true) and repeat step 1

[Edit]

Now that privacy.resistFingerprinting.letterboxing.rememberSize defaults to false, test steps become:

1. Start the Tor Browser and set the new privacy.resistFingerprinting.letterboxing.rememberSize pref to true
2. Restart the Tor Browser and verify that first window is of the expected rounded size (1400x900), but new ones reuse possibly resized dimension as long as letterboxing is enabled
3. Turn the privacy.resistFingerprinting.letterboxing pref to false and verify that new windows get properly force-rounded
4. Turn the new privacy.resistFingerprinting.letterboxing.rememberSize pref to false and revert privacyprivacy.resistFingerprinting.letterboxing to its default (true), and verify that new windows get properly force-rounded