Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked.

Merge Info

Related Issues

• #42443 (closed)

Backporting

Timeline

• Immediate: patchset needed as soon as possible
• Next Minor Stable Release: patchset that needs to be verified in nightly before backport
• Eventually: patchset that needs to be verified in alpha before backport
• No Backport (preferred): patchset for the next major stable

(Optional) Justification

• Emergency security update: patchset fixes CVEs, 0-days, etc
• Censorship event: patchset enables censorship circumvention
• Critical bug-fix: patchset fixes a bug in core-functionality
• Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
• Sponsor required: patchset required for sponsor
• Localization: typos and other localization changes that should be also in the release branch
• Other: please explain

Merging

• Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
• Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
  • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking

• Link resolved issues with appropriate Release Prep issue for changelog generation

Review

Request Reviewer

• Request review from an applications developer depending on modified system:
  • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
  • accessibility : henry
  • android : clairehurst, dan
  • build system : boklm
  • extensions : ma1
  • firefox internals (XUL/JS/XPCOM) : ma1
  • fonts : pierov
  • frontend (implementation) : henry
  • frontend (review) : donuts, richard
  • localization : henry, pierov
  • macos : clairehurst, dan
  • nightly builds : boklm
  • rebases/release-prep : dan, ma1, pierov, richard
  • security : ma1
  • signing : boklm, richard
  • updater : pierov
  • misc/other : pierov, richard

Change Description

How Tested

Resize a window so that some letterboxing margin appears, then double click the margin to shrink the outer window back to fit the rounded content area with no margin. Try with different size and also extra browser chrome (notification bars, dev tools, side panel...)

assigned to @ma1

requested review from @richard

Cooking test builds for @donuts, @thorin & @ruihildt.

Notice that @donuts was skeptic about the zoom-out cursor, but I did include it in this MR and testbuild so everyone gets a sense of how it looks & feels in action. You can easily turn it off for comparison from the Browser Toolbox by disabling the .letterboxing .browserStack CSS rule. A possible alternative would be a custom cursor representing the shrinking action somehow, but of course if the default cursor (which IMHO is bad for discoverability) is preferred I'll just drop it from the final commit.

Testbuilds.

Side note: now that there's a method shrinking down to rounded size, adding a context menu to the letterbox area with this command plus a learn more and a shortcut to betterboxing option could be a further usability / discoverability step.

With regards to mouse icons and other stuffs, this seems like a problem for UX to play around with :) I agree with it being double-click to resize/revert to avoid misclicks causing problems, but I appreciate the difficulty in telegraphing something is double-clickable to the user.

approved this merge request

@ma1 code's simple enough, lgtm presuming UX sign-off

approved this merge request

added 239 commits

• 30db61ea...6e8ffd46 - 229 earlier commits
• b19933b1 - Bug 11698: Incorporate Tor Browser Manual pages into Tor Browser
• e4ec32e1 - Bug 41435: Add a Tor Browser migration function
• 3ad54e3a - Bug 42110: Add TorUIUtils module for common tor component methods.
• a05def09 - Bug 40701: Add security warning when downloading a file
• e1fc34c9 - Bug 41736: Customize toolbar for tor-browser.
• e615942e - Bug 41728: Pin bridges.torproject.org domains to Let's Encrypt's root cert public key
• fc282177 - Customize moz-toggle for tor-browser.
• 0be8ae4f - Bug 41822: Unconditionally disable default browser UX in about:preferences
• a4804466 - Temporary commit: manually place generated wasm files
• c99204f2 - Bug 42443: Shrink window to match letterboxing size when the emtpy area is clicked.

Compare with previous version

marked this merge request as draft from ma1/tor-browser@10df2d2d

marked this merge request as ready

changed target branch from tor-browser-115.8.0esr-13.5-1 to tor-browser-115.9.0esr-13.5-1

resolved all threads

merged

cherry-picked as base-browser@aefa5f37 and mullvad-browser@bec1f691