Skip to content

Add a loading icon for Lox invites

Merge Info

Related Issues



  • Immediate: patchset needed as soon as possible
  • Next Minor Stable Release: patchset that needs to be verified in nightly before backport
  • Eventually: patchset that needs to be verified in alpha before backport
  • No Backport (preferred): patchset for the next major stable

(Optional) Justification

  • Emergency security update: patchset fixes CVEs, 0-days, etc
  • Censorship event: patchset enables censorship circumvention
  • Critical bug-fix: patchset fixes a bug in core-functionality
  • Consistency: patchset which would make development easier if it were in both the alpha and release branches; developer tools, build system changes, etc
  • Sponsor required: patchset required for sponsor
  • Localization: typos and other localization changes that should be also in the release branch
  • Other: please explain


  • Merge to tor-browser - !fixups to tor-browser-specific commits, new features, security backports
  • Merge to base-browser - !fixups to base-browser-specific commits, new features to be shared with mullvad-browser, and security backports
    • NOTE: if your changeset includes patches to both base-browser and tor-browser please clearly label in the change description which commits should be cherry-picked to base-browser after merging

Issue Tracking


Request Reviewer

  • Request review from an applications developer depending on modified system:
    • NOTE: if the MR modifies multiple areas, please /cc all the relevant reviewers (since gitlab only allows 1 reviewer)
    • accessibility : henry
    • android : clairehurst, dan
    • build system : boklm
    • extensions : ma1
    • firefox internals (XUL/JS/XPCOM) : ma1
    • fonts : pierov
    • frontend (implementation) : henry
    • frontend (review) : donuts, richard
    • localization : henry, pierov
    • macos : clairehurst, dan
    • nightly builds : boklm
    • rebases/release-prep : dan, ma1, pierov, richard
    • security : ma1
    • signing : boklm, richard
    • updater : pierov
    • misc/other : pierov, richard

Change Description

Add a loading icon for Lox invites.

Also reduce the amount of focus-jumping by keeping the focus on the disabled button.

Also change the focus of the last provideBridgeDialog page to be the table of bridges. NVDA did not announce the focus when it was set to the dialog itself.

How Tested

Open "Replace bridges" dialog in "about:preferences#connection". Tried with both bridge addresses and lox invites. Lox invite will show the loading icon (an already-used invite will be enough to see the loading icon, followed by an error message).

For the lox invite dialog, I made the "Show invites" button visible in "about:preferences#connection" by using my existing lox bridges and added a fake generated invite by making lox.settings.invite non-empty and restarting. After clicking "Show invites", in the console for loxInviteDialog.xhtml I made the "Request new invite" button active by adding:

gLoxInvites._remainingInvites = 1;

then you can click the button to see the loading icon, and it will eventually fail. Alternatively, you could use the commented-out fake Lox module.

Merge request reports