Tor Launcher hangs with 33533+5 branch

mcs/brade pointed to me that there seems to be a Tor Launcher deadlock inside a call to writeBytes() for the control port connection, with the latest 33533+5 branch from legacy/trac#33533 (moved).

They tested a debug build in macOS, but it also happens to me with a testbuild-linux-x86_64 build.

added TorBrowserTeam202006R in Legacy / Trac component::applications/tor launcher in Legacy / Trac ff78-esr in Legacy / Trac owner::brade in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac reviewer::acat in Legacy / Trac severity::normal in Legacy / Trac status::closed in Legacy / Trac type::defect in Legacy / Trac labels

Let's tentatively assign this to mcs/brade as they started to look into that and have the time for it.

Trac:
Owner: tbb-team to brade
Cc: N/A to mcs, tbb-team

Kathy and I found the cause as well as a fix. Please review: https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug34164-01&id=98f3df12d48daf277f2e3f056600c64294c628c1

Trac:
Status: assigned to needs_review
Keywords: ff78-esr TorBrowserTeam202005 deleted, ff78-esr TorBrowserTeam202005R added

Works fine for me. I agree that the long-term solution should be to switch to non-blocking sockets, but I understand that would mean a much bigger change than this. So I think this is ok for now.

Ok to merge in a esr78 branch.

Trac:
Status: needs_review to merge_ready

Trac:
Reviewer: N/A to acat

Moving review tickets.

Trac:
Keywords: ff78-esr TorBrowserTeam202005R deleted, TorBrowserTeam202006R, ff78-esr added

Thanks everyone. This landed on master (commit 98f3df12d48daf277f2e3f056600c64294c628c1), closing.

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

moved from legacy/trac#34164 (moved)

added Bug label and removed 1 deleted label

removed 1 deleted label

mentioned in issue #40004 (closed)