Skip to content
Snippets Groups Projects

enable landscape mode, basic landscape mode support

Merged cyberta requested to merge landscape_mode into main

closes #200 (closed) related to #183 (closed)

!122 (merged) should be reviewed and merged first

Edited by cyberta

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • cyberta added 1 commit

    added 1 commit

    • 62aef2d1 - change screen orientation behavior: show Android's orientation change floating...

    Compare with previous version

  • cyberta resolved all threads

    resolved all threads

  • cyberta added 5 commits

    added 5 commits

    • 62aef2d1...6cde6403 - 3 commits from branch main
    • a576d7f6 - enable landscape mode, basic landscape mode support
    • e2e5eba3 - change screen orientation behavior: show Android's orientation change floating...

    Compare with previous version

  • Author Maintainer

    @kwadronaut ready for another quick review

  • I'll do another test round on a device.

  • added Doing label

  • kwadronaut added 9 commits

    added 9 commits

    • e2e5eba3...d6056c12 - 7 commits from branch main
    • a7c39ca9 - enable landscape mode, basic landscape mode support
    • 1ff0a68a - change screen orientation behavior: show Android's orientation change floating...

    Compare with previous version

  • I can't actually hit the connect button anymore, with the latest pipeline from here. Same for exit location button.

    Edited by kwadronaut
  • See as well the alignment in the screenshot: image

  • removed Doing label

  • Fwiw, I tried !122 (merged) again, that one does work fine. cc1bad2c this one from main as well.

  • Introduced in d6056c12

  • Author Maintainer

    hm... I'm testing with different devices and cannot reproduce the issue yet. Which device are u using? Do you know which screen resolution you're phone has?

    Edited by cyberta
  • Author Maintainer

    Did you find any pre-condition to get into this state where the buttons are missing?

  • Author Maintainer

    So far I've been testing on a Samsung Galaxy S4 mini (by far smallest screen size I have), Pixel 8a, Samsung S5, Samsung J3, all have different Android versions (Lineage based) reaching from Android 8 to android 14.

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading