"Missing previous key" warnings on restarting onion service
Sometimes (but not always) when I restart an onion service, I get a bunch of warnings like this:
2023-12-13T13:25:58Z ERROR tor_hsservice::ipt_mgr: HS service hewwo missing previous key ArtiPath("hs/hewwo/ipts/k_hss_ntor+398509d88033d16af8ef891fd3970d6f189e4a215ea6b40ebab6ea080c29dad4"), regenerating
2023-12-13T13:25:58Z ERROR tor_hsservice::ipt_mgr: HS service hewwo missing previous key ArtiPath("hs/hewwo/ipts/k_sid+398509d88033d16af8ef891fd3970d6f189e4a215ea6b40ebab6ea080c29dad4"), regenerating
2023-12-13T13:25:58Z ERROR tor_hsservice::ipt_mgr: HS service hewwo missing previous key ArtiPath("hs/hewwo/ipts/k_hss_ntor+44b23ce9420e67a94dd88c5529832adcaee6f8af227382e6d41daf643ca5ee82"), regenerating
2023-12-13T13:25:58Z ERROR tor_hsservice::ipt_mgr: HS service hewwo missing previous key ArtiPath("hs/hewwo/ipts/k_sid+44b23ce9420e67a94dd88c5529832adcaee6f8af227382e6d41daf643ca5ee82"), regenerating
2023-12-13T13:25:58Z ERROR tor_hsservice::ipt_mgr: HS service hewwo missing previous key ArtiPath("hs/hewwo/ipts/k_hss_ntor+3c8775e01e11ed6f6ea72a8057f425253d4584d7ff52c0487fbf88ffa32b18d3"), regenerating
2023-12-13T13:25:58Z ERROR tor_hsservice::ipt_mgr: HS service hewwo missing previous key ArtiPath("hs/hewwo/ipts/k_sid+3c8775e01e11ed6f6ea72a8057f425253d4584d7ff52c0487fbf88ffa32b18d3"), regenerating
There are two problems here:
First, these should not be at ERROR
: We should only use ERROR for fatal problems.
Second, they really shouldn't be happening.