Should we split up the MissingIdKeypair error case?
I think that the MissingIdKeypair
error might be covering too many cases. Right now, IIUC, it can mean:
- "We forgot to generate an identity key for this onion service somehow!"
- "This service is set up to run in offline-keygen mode, and we aren't prepared to deal with that."
- "This service is set up to run in offline-keygen mode but we are missing keys that we should have been given, like the public hs_id key."
I think it makes sense to leave it as-is for now, until we build offline-keygen mode. That is, to have a single MissingIdKeypair error type, and to give it ErrorKind::Internal
.
(I don't think this is MUST.)
cc @gabi-250 for your opinion here