Reconsider usage of unbounded channels in tor-rtcompat's TaskSchedule
The following discussion from !429 (merged) should be addressed:
-
@nickm started a discussion: (+1 comment) Did you consider using
postage::watch
or something similar here? Unbound channels are scary to me, and I think these commands are all basically idempotent.(We can change the backend later by adding a ticket.)
We should probably review usage of TaskSchedule
after we've integrated it into more places in the codebase (specifically, after #90 is fully done), and decide to either
- replace the unbounded channel with a
postage::watch
- keep it as is, if it turns out that we rely on no commands being dropped (e.g. if we add a "fire unless already scheduled" command or something like that), and document this decision in the code.