Implement octal escapes in PT parsing (or change the spec)
The pluggable transport spec states that some strings passed from PT to host can be Tor CStrings:
The MESSAGE value is a human readable string formatted by the PT. The
<Message> contains the log message which can be a String or CString (see
section 2 in control-spec.txt).
According to control-spec.txt, a CString can include octal escapes:
in a CString, the escapes "\n", "\t", "\r", and the octal escapes
"\0" ... "\377" represent newline, tab, carriage return, and the
256 possible octet values respectively.
We currently don't implement this, but maybe we should? (Or, we should change the spec to clarify that you can't use these and simplify that way.)
The following discussion from !779 (merged) should be addressed:
-
@nickm started a discussion: Let's open a ticket for this, and additionally add some kind of a "not implemented" error.
That way if anybody actually uses these escapes, we'll learn about it instead of getting silent miscomputations.