AbstractSpec SupportedCircUsage restrict_mut vs supports
In impl crate::mgr::AbstractSpec for SupportedCircUsage
, supports
and restrict_mut
contain extremely similar code.
-
This should be unified.
-
Note that
supports
checksExit.ports
butrestrict_mut
does not modifyports
:
16:07 <+Diziet> nickm: I see that supports does something wioth
TargetCircUsage::Exit.ports and restrict_mut doesn't. Is that
correct ?
16:26 <+nickm> Diziet: yeah, arguably restrict_mut should do that check too.
16:27 <+nickm> (Diziet: I say "arguably" because the "requirements" section on
restrict_mut says that it shouldn't be called in that case.)
I'm not sure that's right but we are too busy now to look into this properly. (CC @nickm)