arti config variable connect_to_onion_services is not ever built, nor honoured
The #[cfg]
is wrong, so this is never compiled it. Also, nothing reads it.
See also !1113 (closed) where we're adding a setter for it. I think ideally that setter ought to be available even in non-HS builds. I feel there's some risk of reintroducing the "we ignore this config setting" bug, eg by mixing up feature names, but I'm not sure how to avoid that in the future.
Perhaps we can make sure we get a dead code warning? And change the type to ()
if we're not building with HS support?