Skip to content

Actually check kind() on HsIdParseError, and bubble it upwards for SOCKS error.

From discussion on !1279 (merged), @Diziet says

nothing actually calls .kind() on an HsIdParseError. Instead, there is a tangled mess in tor-client. address.rs is required (by its surroundings) to produce a TorAddrError; that is done in err.rs with a From impl which discards the HsIdParseError. Then TorAddrError doesn't implement ErrorKind. Instead, it is just stuffed into an ErrorDetail::Address which results in EK::InvalidStreamTarget.

I guess this wants a ticket. Certainly it's a can of worms we don't want to block this MR with.