Skip to content

Draft: Refactor `tor_netdoc::Error`

gabi-250 requested to merge gabi-250/arti:netdoc-errors into main

This addresses some tech debt (certain ParseErrorKind variants are validation errors rather than parsing errors). A possible solution is to introduce a separate error type for these (which is what I've done in this MR).

There are other ways to refactor tor_netdoc::Errors. I'm happy to discuss other possibilities if we think this one is suboptimal.

It also fixes #852 (closed), which was caused by !1153 (merged) (parse_decrypt_validate() is called from tor-hsclient, but tor-hsclient doesn't enable the experimental-api feature, which is required for parse_decrypt_validate()).

Merge request reports

Loading