Skip to content

Revise fixup-features to be closer to something we can use

Nick Mathewson requested to merge nickm/arti:better-fixup-features into main

We have a work-in-progress program called "fixup-features" that is meant to enforce various rules on the features in our crates. The trouble is, we've never run it successfully: The one time we tried, we ran into trouble. (See !1068 (closed))

This branch tries to rewrite "fixup-features", clean it up a tiny bit, and make its behavior closer to what we really need.

Notes:

  • @Diziet suggested that I use petgraph in this rewrite. I tried, but it was intractable.
  • The code is a bit hacky, since it isn't anything we're shipping in production.
  • The code is quite inefficient, but it shouldn't matter: it runs in less than a second.

Merge request reports