Skip to content

fixes deadlock in TorClient::reconfigure

Janosch Gräf requested to merge sw1tch/arti:sw1tch/fix_reconfigure_deadlock into main

This fixes a deadlock in TorClient::reconfigure.

When reconfigureis called with how set to Reconfigure::AllOrNothing the function recurses while already holding the reconfigure_lock, thus trying to acquire it a second time and deadlocking.

This pull request fixes this, by moving the actual reconfiguration code into a separate method. I also added a test, but it doesn't really check anything - only that the reconfigure is successful.

Merge request reports