Skip to content

tor-netdoc: Use the new HandshakeType enum to represent CREATE2 HTYPEs.

gabi-250 requested to merge gabi-250/arti:create2-formats into main

Representing the supported HTYPEs as HandshakeTypes instead of u32s makes it more difficult to pass in wrong/invalid values to HsDescBuilder::create2_formats.

This also fixes a descriptor publisher bug spotted by @jnewsome, where the advertised CREATE2 HTYPEs included HTYPE 1, which is actually supposed to be a reserved value. The publisher now only advertises the NTOR HTYPE (just like C Tor).

Merge request reports

Loading