Skip to content

Convert to the latest versions of dalek-cryptography

Nick Mathewson requested to merge nickm/arti:semver-breaking-upgrade-of-the-daleks into main

The main changes that we have to adjust for are as follows:

  • In x25519-dalek:

    • StaticSecret is now behind a feature.
    • StaticSecret::new is deprecated in favor of StaticSecret::random_from_rng.
    • StaticSecret no longer does its own clamping.

  • In ed25519-dalek:

    • SecretKey has (in effect) been renamed to SigningKey. The name SecretKey is now an alias for [u8; 32].
    • SigningKey is effectively a keypair, since it contains a public key as well.
    • PublicKey has been renamed to VerifyingKey.
    • The functions to extract a signing key and verifying key have been renamed as you might expect.
    • ExpandedSecretKey has been moved to hasmat and no longer implements sign.
    • ExpanededSecretKey now has as its elements a scalar and a hash prefix.
    • Various functions that took &[u8] now take &[u8; N].
    • We no longer need a wrapper for older versions of rand.

There is a single test in tor-keymgr that does not pass. I've marked it as ignore for now, in hopes that @gabi-250 can help me figure it out.

This closes #808 (closed). There are several changes I want to make before we merge, however. They are marked with TODO DALEK.

Merge request reports