tor-hsservice: replay: Recover from partial writes (!1920) · Merge requests · The Tor Project / Core / Arti

Ian Jackson requested to merge Diziet/arti:replay into main Jan 25, 2024

Most of the effort here was in the test case, which is quite a contraption.

I discovered that the issue is theoretical - it doesn't occur with the current implementation of BufWriter. I still think we should have the test case, at least.

If, in the future, BufWriter documents the extra guarantee, we could revert "tor-hsservice: replay: Recover from partial writes".

tor-hsservice: replay: Recover from partial writes

Merge request reports