tor-proto datastream: Do not dump packet data in DataWriterImpl
It looks like the merge of !351 (merged) and my fix crossed in the post.
18:43 <trinity[m]1> arti!351 may "export" whatever user is sending/receiving
over tor (through DataReaderImpl and DataWriterImpl). Is
that fine?
18:43 -tor:#tor-dev-
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/351 -
impl Debug for DataStream (and its components)
18:45 <+nickm> IMO no
18:45 <+nickm> (good catch)
18:46 <+nickm> probably better to go with a less verbose Debug
18:48 <+Diziet> OK, I will do that.
18:58 <+Diziet> nickm, trinity[m]1: I have done that to arti!351.
18:58 -tor:#tor-dev-
https://gitlab.torproject.org/tpo/core/arti/-/merge_requests/351 -
18:58 <+Diziet> trinity[m]1: Well spotted. I had not intended to dump the
buffers.
18:58 <+Diziet> I am still dumping the `StreamTarget`. I think making that
optional is part of "safe logging"(by which I meant that it is OK to dump the StreamTarget now)