Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Arti Arti
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 137
    • Issues 137
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 13
    • Merge requests 13
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • The Tor Project
  • Core
  • ArtiArti
  • Merge requests
  • !608

Bump `base64ct` crate `1.5.0` -> `1.5.1`

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged arturomf94 requested to merge arturomf94/arti:bump-base64ct into main Jun 28, 2022
  • Overview 4
  • Commits 1
  • Pipelines 1
  • Changes 3

This new release of base64ct checks for invalid symbols in non-padded inputs for decoding. Therefore, we can get rid of the logic implemented in !600 (merged), as pointed out by @Diziet here.

Note: there was a test that was incorrectly passing in the last implementation, so I've modified to fit expected behaviour. In particular, we were correctly decoding "Bg=" because the logic added the necessary extra = characters to be a valid padding... However, strictly speaking, the padding in this input is invalid, so the decoding should fail.

Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: bump-base64ct