Skip to content

Fix nightly clippy

trinity-1686a requested to merge trinity-1686a/arti:fix-nightly-clippy into main

This does enough for the CI to turn green, but there are still lints failing (but only with warning, not errors):

  • unused_peekable: I'm pretty sure these are false positive, and have reported it upstream
  • result_large_err: we should probably try to fix these ones, large Err(_) means the happy path of Ok(_) still has to copy a big struct. However doing so might require breaking changes (like Boxing the Err value)
  • mut_mutex_lock: seems like false positive too. There is a recently fixed issue upstream. The fix was merged a week ago, so it's odd we don't have it (or we do and it's insufficient?), but I'm not sure how clippy releases are made, so maybe it's normal the fix isn't available yet?

Merge request reports