Skip to content

CircMgr: Refactor DirSpecificTarget constructor

Nick Mathewson requested to merge nickm/arti:refactor_into_ownedchantarget into main

This commit uses ChanTarget rather than Into<OwnedChanTarget> as the constraining on the argument to get_or_launch_dir_specific(). Making this change allows us to remove From<&T> for OwnedChanTarget, which is IMO undesirable: from_chan_target is explicit for a reason, since it clones data.

As a downside, this change means that we can no longer trivially pass in an OwnedChanTarget and not get it copied. (But we never do that.)

No semver change needed, since these APIs haven't been released.

Found while writing unit tests.

Assigning review to @Diziet since they wrote the original code.

Merge request reports