Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
arti
arti
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 34
    • Issues 34
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 0
    • Merge Requests 0
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Package Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • The Tor Project
  • Core
  • artiarti
  • Merge Requests
  • !9

Merged
Opened Dec 23, 2020 by George Kadianakis@asnOwner

dirmgr: Handle errors in download_mds()

  • Overview 0
  • Commits 2
  • Pipelines 1
  • Changes 1

Another silly MR handling errors.

One question about the code that might warrant some extra documentation: a) How come we create an MicrodescReader with AnnotationsNotAllowed only later to iterate over its annotations?

A question about the MR:

  1. Are there more graceful ways to handle these errors instead of additional if blocks? We tried to do it with unwrap_or_else() but couldn't figure out how to do it because the closure had to return a vector.
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: tpo/core/arti!9
Source branch: download_mds_errors