Enable control port in chutney Tor clients

I'd like to be able to use chutney to perform integration testing for OnionBalance. I need access to a Tor client's control port but the control port is not enabled in the current client.tmpl.

I've pushed a trivial patch to my Github repo at https://github.com/DonnchaC/chutney/pull/1/files

added SponsorS in Legacy / Trac component::core tor/chutney in Legacy / Trac owner::nickm in Legacy / Trac priority::medium in Legacy / Trac resolution::fixed in Legacy / Trac status::closed in Legacy / Trac type::enhancement in Legacy / Trac labels

I can look into this.

Trac:
Status: new to needs_review

Branch: client-control-port Repository: https://github.com/DonnchaC/chutney.git Commits:

• Enable control port in client.tmpl

Review

This change can be merged:

• I have confirmed that clients and bridge clients generate ControlPort and CookieAuthentication lines
• I have confirmed that nyx can connect to the chutney client's control port
• Existing code and src/test/test-network.sh tests work as expected

Using ControlSocket doesn't expose the port to other processes. Note: the ControlSocket line would be disabled by chutney on older versions of Tor which don't have that feature.

donncha, would you like to change the patch to use ControlSocket instead?

Trac:
Status: needs_review to needs_information

I think we can we merge this patch as is. Using ControlSocket will only work on the latest tor versions, so it's best to use ControlPort.

It's in DonnchaC's github repository at:

Branch: client-control-port Repository: ​https://github.com/DonnchaC/chutney.git Commits:

• Enable control port in client.tmpl

Trac:
Status: needs_information to needs_review

nickm, this can be merged

Trac:
Keywords: N/A deleted, SponsorS added

Looks fine; merged

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved from legacy/trac#16438 (moved)

added Feature label and removed 1 deleted label

removed 1 deleted label