chutney does not fail on some SOCKS errors

When tor can't make a connection, and sends back a SOCKS error, chutney keeps on rapidly sending SOCKS requests. Instead, chutney should fail.

I think we introduced this bug when we started using asyncore.

I have worked around the bug using a 5 second asyncore timeout, but we should come up with a permanent fix.

I think nickm might be able to help with this issue, because he wrote that code.

Trac:
Parent Ticket: legacy/trac#33050 (moved)

added component::core tor/chutney in Legacy / Trac easy in Legacy / Trac ipv6 in Legacy / Trac outreachy-ipv6 in Legacy / Trac owner::c in Legacy / Trac parent::33050 in Legacy / Trac points::1 in Legacy / Trac priority::medium in Legacy / Trac prop311 in Legacy / Trac severity::normal in Legacy / Trac sponsor::55-can in Legacy / Trac status::assigned in Legacy / Trac type::defect in Legacy / Trac labels

Trac:
Keywords: N/A deleted, outreachy-ipv6 added

Trac:
Cc: nickm, teor to nickm
Parent: legacy/trac#33232 (moved) to legacy/trac#33050 (moved)

Trac:
Keywords: N/A deleted, easy added

Assuming workaround is at Traffic.py:441? I see the timeout was adjusted in 95ce144c which has more changes than just that line.

What's a reproducible way to cause a failure case here? Or, at least, will decreasing the timeout back to 0.2 be enough to encourage failure?

Trac:
Owner: N/A to c
Cc: nickm to nickm, c@chroniko.jp
Status: new to assigned

changed time estimate to 8h

mentioned in issue legacy/trac#33050 (moved)

moved from legacy/trac#33598 (moved)

mentioned in issue #33050 (closed)

There was some discussion on tor-dev@ about this issue while the issue tracker was read-only, but I'll divert it back over to this ticket.

where is Chutney actually initiating SOCKS connections to Tor during tests?

It's in Traffic.py, Source.handle_connect()

Sorry, what I meant to ask is "what tests are making SOCKS connections?" There are many tests in networks/ all with sparse descriptions, and there also seems to be separate tests outside of the networks/ directory that test other components of Tor as well as Chutney itself.

added Bug First Contribution labels and removed 1 deleted label

ok, in that case I'd start with the stuff triggered from tor's "make test-networks". I believe that invokes tools/test-network.sh in chutney, which invokes tools/test-network-impl.sh, which uses "chutney verify" to launch SOCKS tests. Is that what you were asking?

mentioned in commit 9ab583bb

We could do this under sponsor 55 O1.3.

added 1 deleted label

added Backlog label

added IPv6 label and removed 1 deleted label

added Doing label and removed Backlog label

added Next label and removed Doing label