oniontunnel clippy fails
The pipelines for rust-clippy have been failing.
For example https://gitlab.torproject.org/tpo/core/onionmasq/-/jobs/450955
error: use of `or_insert_with` to construct default value
--> crates/onion-tunnel/src/dns.rs:106:14
|
106 | .or_insert_with(IsolatedCookies::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
= note: `-D clippy::unwrap-or-default` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::unwrap_or_default)]`
error: use of `or_insert_with` to construct default value
--> crates/onion-tunnel/src/dns.rs:113:14
|
113 | .or_insert_with(IsolatedCookies::new)
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `or_default()`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unwrap_or_default
error: this loop never actually loops
--> crates/onion-tunnel/src/proxy.rs:237:9
|
237 | / loop {
238 | | tokio::select! {
239 | | result = arti_to_tun => break result,
240 | | result = tun_to_arti => break result,
241 | | }
242 | | }
| |_________^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
= note: `#[deny(clippy::never_loop)]` on by default
error: could not compile `onion-tunnel` (lib) due to 3 previous errors