NetworkTeam's Gitlab Code Review Workflow
This is how the network team uses Gitlab to do code reviews.
Marking something for review
When you write code that you need reviewed, you create a Gitlab Merge Request.
You should also make your branch against the target maint-0.x.y branch, and your MR request against that target branch. Finally, if the MR is a backport candidate you should mention it in your MR message.
Assigning reviews
Our triage-bot will automatically assign a member of the network team as a
reviewer.
Reviewing
If you are happy, use the Approve button.
If it needs revision, put in the Needs Revision label (optional).
If the branch needs to get backported:
- Give the MR the Backport label
- Put the MR into the latest milestone to which it has not been backported.