Skip to content
Snippets Groups Projects
  • Nick Mathewson's avatar
    ce854a8d
    Add -ftrapv to gcc-hardening ... mostly! · ce854a8d
    Nick Mathewson authored
    We know there are overflows in curve25519-donna-c32, so we'll have
    to have that one be fwrapv.
    
    Only apply the asan, ubsan, and trapv options to the code that does
    not need to run in constant time.  Those options introduce branches
    to the code they instrument.
    
    (These introduced branches should never actually be taken, so it
    might _still_ be constant time after all, but branch predictors are
    complicated enough that I'm not really confident here. Let's aim for
    safety.)
    
    Closes 17983.
    ce854a8d
    History
    Add -ftrapv to gcc-hardening ... mostly!
    Nick Mathewson authored
    We know there are overflows in curve25519-donna-c32, so we'll have
    to have that one be fwrapv.
    
    Only apply the asan, ubsan, and trapv options to the code that does
    not need to run in constant time.  Those options introduce branches
    to the code they instrument.
    
    (These introduced branches should never actually be taken, so it
    might _still_ be constant time after all, but branch predictors are
    complicated enough that I'm not really confident here. Let's aim for
    safety.)
    
    Closes 17983.