Commit f57b5c48 authored by George Kadianakis's avatar George Kadianakis Committed by Nick Mathewson
Browse files

Fix TROVE-2021-006: Out-of-bounds read on v3 desc parsing

parent adb248b6
Pipeline #7678 failed with stage
in 20 minutes and 31 seconds
o Major bugfixes (security, denial of service, onion services):
- Fix an out-of-bounds memory access in v3 descriptor parsing. Fixes bug
40392; bugfix on This issue is also tracked as
TROVE-2021-006. Reported by Sergei Glazunov from Google's Project Zero.
\ No newline at end of file
......@@ -135,7 +135,7 @@ static token_rule_t hs_desc_superencrypted_v3_token_table[] = {
/* Descriptor ruleset for the encrypted section. */
static token_rule_t hs_desc_encrypted_v3_token_table[] = {
T1_START(str_create2_formats, R3_CREATE2_FORMATS, CONCAT_ARGS, NO_OBJ),
T01(str_intro_auth_required, R3_INTRO_AUTH_REQUIRED, ARGS, NO_OBJ),
T01(str_intro_auth_required, R3_INTRO_AUTH_REQUIRED, GE(1), NO_OBJ),
T01(str_single_onion, R3_SINGLE_ONION_SERVICE, ARGS, NO_OBJ),
......@@ -2312,6 +2312,7 @@ desc_decode_encrypted_v3(const hs_descriptor_t *desc,
/* Authentication type. It's optional but only once. */
tok = find_opt_by_keyword(tokens, R3_INTRO_AUTH_REQUIRED);
if (tok) {
tor_assert(tok->n_args >= 1);
if (!decode_auth_type(desc_encrypted_out, tok->args[0])) {
log_warn(LD_REND, "Service descriptor authentication type has "
"invalid entry(ies).");
Supports Markdown
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment