Skip to content
Snippets Groups Projects
Commit f70f1d28 authored by Nick Mathewson's avatar Nick Mathewson :game_die:
Browse files

Do not printf success messages when we are --quieted or --hushed.

Fixes 14994. Calling this a bug on when --quiet and --hush began to have
their current behavior.
parent 3a68f2f5
No related branches found
No related tags found
No related merge requests found
o Minor bugfixes (command-line interface):
- When "--quiet" is provided along with "--validate-config", do not
write anything to stdout on success. Fixes bug 14994; bugfix on
0.2.3.3-alpha.
- When complaining about bad arguments to "--dump-config", use
stderr, not stdout.
......@@ -2783,8 +2783,8 @@ do_dump_config(void)
} else if (!strcmp(arg, "full")) {
how = OPTIONS_DUMP_ALL;
} else {
printf("%s is not a recognized argument to --dump-config. "
"Please select 'short', 'non-builtin', or 'full'", arg);
fprintf(stderr, "%s is not a recognized argument to --dump-config. "
"Please select 'short', 'non-builtin', or 'full'", arg);
return -1;
}
......@@ -3085,7 +3085,8 @@ tor_main(int argc, char *argv[])
result = 0;
break;
case CMD_VERIFY_CONFIG:
printf("Configuration was valid\n");
if (get_options()->quiet_level)
printf("Configuration was valid\n");
result = 0;
break;
case CMD_DUMP_CONFIG:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment